Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no bash completion for pull-request #1875

Closed
yurikoles opened this issue Sep 16, 2018 · 5 comments
Closed

no bash completion for pull-request #1875

yurikoles opened this issue Sep 16, 2018 · 5 comments

Comments

@yurikoles
Copy link

yurikoles commented Sep 16, 2018

Bash completion doesn't know pull-request command.

@yurikoles yurikoles changed the title no bash completion pull-request no bash completion for pull-request Sep 16, 2018
@mislav
Copy link
Owner

mislav commented Sep 17, 2018

Thanks for reporting. What is your OS and git version?

Have you aliased git=hub? #1792 (comment)

@yurikoles
Copy link
Author

Git 2.19.0/macOS 10.14b11 (Mojave).
Same issue with Git and hub from master.
I have no aliases for hub.

@mislav
Copy link
Owner

mislav commented Sep 17, 2018

Because of how git core bash completions are implemented, in order for hub to extend them, git has to be aliased as hub for now. I haven't been able to work around this, so contributions/fixes welcome.

Try this:

  1. Open a new shell;
  2. alias git=hub;
  3. type git pu and press Tab twice.

Does pull-request show?

@yurikoles
Copy link
Author

yes, it shown

@mislav
Copy link
Owner

mislav commented Sep 18, 2018

Thank you for checking. Then I'll close this as a duplicate of #1792.

In order to get hub aliases working for now, add alias git=hub to your ~/.bash_profile. The completions should also work if your start the command with hub:

$ hub pull-request <TAB>

@mislav mislav closed this as completed Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants