Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PULLREQ_EDITMSG file stays around when pull-request command fails #2450

Open
jkaan opened this issue Jan 22, 2020 · 0 comments
Open

PULLREQ_EDITMSG file stays around when pull-request command fails #2450

jkaan opened this issue Jan 22, 2020 · 0 comments
Labels

Comments

@jkaan
Copy link

jkaan commented Jan 22, 2020

Command attempted:

echo "test" | hub pull-request --force --edit -F -

What happened:

First command I ran was: echo "test" | hub pull-request --force --edit -F -. The command is failing since the branch that I'm making a pull request off is not pushed yet (I know this is incorrect).

Next time I ran echo "testanotherone" | hub pull-request --force --edit -F -, the result is still the text "test".
I found out that the file in the .git folder PULLREQ_EDIT_MSG is not deleted if pull-request fails, the fix is probably to do exactly what I mentioned :).

More info:

git version 2.25.0
hub version 2.13.0

@jkaan jkaan added the bug label Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant