Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New dependencies? #110

Closed
ghost opened this issue Sep 20, 2017 · 11 comments · Fixed by #111
Closed

New dependencies? #110

ghost opened this issue Sep 20, 2017 · 11 comments · Fixed by #111
Assignees

Comments

@ghost
Copy link

ghost commented Sep 20, 2017

The test suggest that pydeep and python-magic are new dependencies or at least recommended requirements. If they are, these package names should be mentioned in setup.py's install_requires or extra_requires.

And pydeep does not have a stable release, not a release and not on pypi. The latest release 0.2 is from 2013, 4 years ago. That supports up to python 2.6!

@Rafiot
Copy link
Member

Rafiot commented Sep 20, 2017

They are only recommended, And I'll update setup.py.

The only working version of pydeep is the one you get from the git repo:
pip install git+https://github.com/kbandla/pydeep.git

@ghost
Copy link
Author

ghost commented Sep 20, 2017

The only working version of pydeep is the one you get from the git repo:

Which is a "not very satisfying" situation.

@Rafiot
Copy link
Member

Rafiot commented Sep 20, 2017

Well, the alternative would be to bundle it in pymisp, or not generating ssdeep hashes (again, it's optional).

@Rafiot Rafiot reopened this Sep 20, 2017
@Rafiot
Copy link
Member

Rafiot commented Sep 20, 2017

(I didn't mean to close it)

@ghost
Copy link
Author

ghost commented Sep 20, 2017

I opened kbandla/pydeep#16

@Rafiot
Copy link
Member

Rafiot commented Sep 20, 2017

And as we are at it: using the trunk of lief is currently required, the release 0.7 has a bunch of bugs that are fixed in 0.8 (to me released in the coming weeks).

@ghost
Copy link
Author

ghost commented Sep 20, 2017

And as we are at it: using the trunk of lief is currently required, the release 0.7 has a bunch of bugs that are fixed in 0.8 (to me released in the coming weeks).

Which software are you talking about?

@Rafiot
Copy link
Member

Rafiot commented Sep 20, 2017

@ghost
Copy link
Author

ghost commented Sep 20, 2017

Ah, the other new dependency mentioned in the travis file.

If there's a working stable version, please add a version specifier with the minimum working version in the setup.py file.

@Rafiot
Copy link
Member

Rafiot commented Sep 20, 2017

There is no known working release yet, 0.8 isn't out.

I'll update the minimum working version as soon as it's available.

Rafiot added a commit that referenced this issue Oct 20, 2017
@Rafiot
Copy link
Member

Rafiot commented Oct 28, 2017

@Rafiot Rafiot closed this as completed Oct 28, 2017
3c7 pushed a commit to 3c7/PyMISP that referenced this issue Nov 22, 2017
Add handling a string response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant