Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calls to PyMISP.update with wrong event argument #46

Closed
gcrahay opened this issue Jan 27, 2017 · 1 comment
Closed

Calls to PyMISP.update with wrong event argument #46

gcrahay opened this issue Jan 27, 2017 · 1 comment

Comments

@gcrahay
Copy link

gcrahay commented Jan 27, 2017

I think 619538c introduced a bug in:

  • PyMISP.publish
  • PyMISP.change_threat_level
  • PyMISP.change_sharing_group
  • PyMISP._send_attributes

Example:

def change_threat_level(self, event, threat_level_id):
        e = self._make_mispevent(event)
        e.threat_level_id = threat_level_id
        return self.update(event)

self.update should be called with e as argument, not event.

@Rafiot
Copy link
Member

Rafiot commented Jan 28, 2017

Thanks for the report, fixing!

@Rafiot Rafiot closed this as completed in 14ccf16 Jan 28, 2017
TheDr1ver pushed a commit to TheDr1ver/PyMISP that referenced this issue Mar 9, 2017
Update README.md with install instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants