Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Emoji only in categories if native is present. #13

Closed
rachitGulati opened this issue Oct 3, 2016 · 6 comments
Closed

[Feature] Emoji only in categories if native is present. #13

rachitGulati opened this issue Oct 3, 2016 · 6 comments

Comments

@rachitGulati
Copy link

I want to render the emoji's in the sheet only if native support icon is present.
Can you please suggest where should I change ?.

@rachitGulati rachitGulati changed the title [Feature] Emoji only if native is present. [Feature] Emoji only in categories if native is present. Oct 3, 2016
@EtienneLem
Copy link
Member

Do you have a few examples of emojis that wouldn’t have a native version? I guess it mostly depends on the device/OS. It would help to to know which ones aren’t supported on what device to test the implementation.

We could add a onlyIfNativeIsSupported props to the Picker component.

@rachitGulati
Copy link
Author

rachitGulati commented Oct 4, 2016

So in the image below you can see inside the native there is box "[]" instead of emoji face. I am on Mac OS X Yosemite with Chrome 53.0.2785.

screenshot 2016-10-04 11 18 01

And there are many emoji which are showing this. I am currently using apple sprite. I wanted the native emoji to be shown in my textArea or in input field.

Is there any hotfix for this ? Can you guide me what should I do for it ?

@rachitGulati
Copy link
Author

rachitGulati commented Oct 5, 2016

@EtienneLem Any update ? I am sorry for bothering you but it's a bit urgent for me :( . I would really appreciate any help from your side.

@EtienneLem
Copy link
Member

So I gave it a go, but it doesn’t seem to work.
Check out https://missive.github.io/emoji-mart and check the excludeUnsupportedNativeEmojis checkbox, the Upside-Down Face is still there, correct?

@rachitGulati
Copy link
Author

I don't know what you have fixed but it seems to be working now at least in your demo . Showing right value for 'native' property of the object inside the console. Don't think so checkbox is even working.

@rachitGulati
Copy link
Author

Closing this issue as it is not reproducing any more :)

@EtienneLem thanks for fixing it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants