Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching with "_" and "-" leads to inconsistent results #131

Closed
nolanlawson opened this issue Oct 6, 2017 · 3 comments
Closed

Searching with "_" and "-" leads to inconsistent results #131

nolanlawson opened this issue Oct 6, 2017 · 3 comments

Comments

@nolanlawson
Copy link

There's a slightly surprising situation where if you search for e.g. thinking_fac you won't get :thinking_face:, or if you search for woman-facepalm then you won't get :woman-facepalming:

out

This seems to be due to how we split on - and _ characters, but the fix isn't straightforward so I haven't opened a PR yet.

@nolanlawson
Copy link
Author

I don't have a PR yet, but here's a test to repro the issue: nolanlawson@f47a9ff

@EtienneLem
Copy link
Member

🤔 Must’ve been a regression at some point, searching for thinking-face and thinking face should have exactly the same search results. It used to work, will look into.

@nolanlawson
Copy link
Author

Sweet! Nice fix. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants