Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering emoji without image from search #141

Closed
savardc opened this issue Nov 7, 2017 · 3 comments
Closed

Filtering emoji without image from search #141

savardc opened this issue Nov 7, 2017 · 3 comments

Comments

@savardc
Copy link

savardc commented Nov 7, 2017

We're having some issues with search results containing emoji with no image.

So far, the only way I found to check if an emoji has an image is to use the has_img* properties on the data returned by getData.

I would be happy to work on a PR but I'm not sure about the best way to fix this?

  • Add an option to filter out emoji with no images from the search results
  • Provide the necessary information to emojisToShowFilter
  • Expose the has_img* properties through emojiIndex.emojis

Any thoughts?

@EtienneLem
Copy link
Member

Do you have an example? I was sure this was already handled 🤔

@savardc
Copy link
Author

savardc commented Nov 8, 2017

:staff_of_aesculapius: with the emoji-one set. The Emoji component returns null so is not displayed in the search results in the picker but there's no easy way to remove it from the result of the search function

The check for the image is here: https://github.com/missive/emoji-mart/blob/master/src/components/emoji.js#L99

@EtienneLem
Copy link
Member

Figured the best way for now would be to provide more data to emojisToShowFilter, just like it does in the Picker component. Preparing v2.2.0 release as we speak.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants