Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing emojis are still rendered causing layout issues #160

Closed
pederjohnsen opened this issue Jan 16, 2018 · 2 comments
Closed

Missing emojis are still rendered causing layout issues #160

pederjohnsen opened this issue Jan 16, 2018 · 2 comments

Comments

@pederjohnsen
Copy link

Missing emojis are still rendered in the picker causing layout issues
https://i.imgur.com/PCMHkXl.png?1

It seems weird to render them if there is no emoji to display.

@ajbeaven
Copy link

I think perhaps #158 will resolve this. It's merged but not yet released.

@EtienneLem
Copy link
Member

These are native emojis, correct? There’s not much we can do to prevent that from happening. Support is different depending on the OS and browser being used, so it needs to be tested at runtime. There’s a branch (https://github.com/missive/emoji-mart/tree/exclude-unsupported-native-emojis) with an experiment, but it has proven not to be 100% reliable and most likely poor for performance. It requires writing and reading dataURL from a canvas for each emoji.

Using native emojis is much faster and always look sharper, but unfortunately has important drawbacks.

@ajbeaven Oh thanks for the reminder, I’ll do that today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants