Fallback doesn't fire if the emoji name isn't recognised

[andrewhillcode]

I'm wrapping everything that matches my colon regex like :crocodile: and making them Emoji components.

The fallback only triggers when a recognised emoji name (like :shrug:) is not supported in certain sets (like Messenger). Using something like :shrugtest: won't trigger the fallback and the Emoji component will render nothing instead of a string: :shrugtest:

[darklightblue]

I am actually facing the same issue, Upon checking the source code it seems that this is where the bug is:

emoji-mart/src/components/emoji/nimble-emoji.js

Line 89 in b1c499f

if (!data) {

(there should be a fallback here)

  let data = _getData(props)
  if (!data) {
    return null
  }

And:

emoji-mart/src/utils/index.js

Line 81 in b1c499f

return null

   if (data.emojis.hasOwnProperty(emoji)) {
      emojiData = data.emojis[emoji]
    } else {
      return null
    }

[vivaldi-va]

definitely feel that the fallback callback should fire in this case. Perhaps with an additional argument returning the value you added to the emoji prop.

For instance emoji=":foo:" should have the callback arguments of null and :foo:, which would allow rendering a string fallback, for example.

[EtienneLem]

Of course! Made it so fallback always receive the emoji object (if found) and the props. It’s up to the developer to use whatever props they want to handle the fallback. Example in README.

[tuomohopia]

The fallback still appears not to fire if the emoji={..} is an object instead of a string. For example:

emoji={{ id, skin: 1 }}