Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable sorting of frequently used emojis on click #366

Closed
vrizo opened this issue Sep 27, 2019 · 9 comments
Closed

Disable sorting of frequently used emojis on click #366

vrizo opened this issue Sep 27, 2019 · 9 comments

Comments

@vrizo
Copy link

vrizo commented Sep 27, 2019

Hi, @EtienneLem !

Thanks for Emoji Mart — an excellent project which we use on our project!

We faced a problem reported by our users. Sorting of frequently used emojis is annoying because it fires when the user clicks on the emoji.

Catch me if you can

What do you think about disabling sorting on the fly in favor of sorting after component mounting?

I found the same issue here, but the author decided to close it: #265. I don't think that it is a bug, but I think it might be improved.

Thank you!

@vrizo
Copy link
Author

vrizo commented Oct 15, 2019

Hey, @EtienneLem @nolanlawson !

Do you have any thoughts on this?

I noticed that there is the same behavior on macOS in the native mini picker. But it works in full-size native picker in another way. 1:1. Attaching a GIF.

macOS emoji picker

Thank you!

@vrizo
Copy link
Author

vrizo commented Nov 15, 2019

Hi, @EtienneLem @nolanlawson ! Do you have any ideas about this feature? Thanks!

@edgesinghkataria
Copy link

We can give a property to enable/disable this functionality.
Let me know what suits best.
I've fixed this In my current project, will be happy to submit a PR

@EtienneLem
Copy link
Member

I feel like this should be the default and be re-sorted only when mounting

@nolanlawson
Copy link

I agree, having the icons move out from under your mouse is confusing, even if the native macOS emoji picker also does this.

@SaraRandolph
Copy link

Hi all! I have been working on a solution for this and I'm wondering if you guys would be open to reviewing a PR for this issue. This will be my first PR for an open source project so it won't be perfect but it will at least be on the road to a solution for this enhancement!

@EtienneLem
Copy link
Member

@SaraRandolph Absolutely! You will notice that we’ve been pretty slow on reviewing/implementing lately. I will have some time to allocate on this very soon ✌️

@SaraRandolph
Copy link

@EtienneLem sounds good! no rush! I'll make the pr this afternoon. thank you!

@EtienneLem
Copy link
Member

Fixed with #417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants