Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

プッシュ通知のフォロー通知が正しく表示されない #12449

Open
CyberRex0 opened this issue Nov 25, 2023 · 5 comments
Open
Labels
⚠️bug? This might be a bug packages/sw and PWA ServiceWorker and PWA related issue/PR

Comments

@CyberRex0
Copy link
Contributor

💡 Summary

フォローされた時、関係ないプッシュ通知が表示される

🥰 Expected Behavior

フォローされました などというプッシュ通知が表示される

🤬 Actual Behavior

Screenshot_20231125-173551~2

📝 Steps to Reproduce

  1. プッシュ通知を有効にする
  2. フォローされる

💻 Frontend Environment

* Model and OS of the device(s):Xperia 5 IV, Android 13
* Browser: 119.0.6045.163 (Official Build) (64 ビット) 
* Server URL: https://misskey.io/, https://mi.cbrx.io/
* Misskey: 2023.11.1

🛰 Backend Environment (for server admin)

* Installation Method or Hosting Service:
* Misskey:
* Node:
* PostgreSQL:
* Redis:
* OS and Architecture:
@CyberRex0 CyberRex0 added the ⚠️bug? This might be a bug label Nov 25, 2023
@kakkokari-gtyih kakkokari-gtyih added the packages/sw and PWA ServiceWorker and PWA related issue/PR label Nov 25, 2023
@CyberRex0
Copy link
Contributor Author

@syuilo

@syuilo
Copy link
Member

syuilo commented Dec 22, 2023

@kakkokari-gtyih
Copy link
Contributor

対応する通知の文言がswに用意されてないのでは

@anatawa12
Copy link
Member

export async function createNotification<K extends keyof PushNotificationDataMap>(data: PushNotificationDataMap[K]): Promise<void> {
const n = await composeNotification(data);
if (n) {
return globalThis.registration.showNotification(...n);
} else {
console.error('Could not compose notification', data);
return createEmptyNotification();
}
}

ここでcreateEmptyNotificationにフォールバックされてそう

@CyberRex0
Copy link
Contributor Author

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️bug? This might be a bug packages/sw and PWA ServiceWorker and PWA related issue/PR
Projects
None yet
Development

No branches or pull requests

4 participants