Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

チャートのレコード挿入をバルクにする #7352

Closed
syuilo opened this issue Mar 14, 2021 · 0 comments · Fixed by #7360
Closed

チャートのレコード挿入をバルクにする #7352

syuilo opened this issue Mar 14, 2021 · 0 comments · Fixed by #7360
Labels
✨Feature This adds/improves/enhances a feature packages/backend Server side specific issue/PR 🐢Performance Efficiency related issue/PR

Comments

@syuilo
Copy link
Member

syuilo commented Mar 14, 2021

Summary

https://github.com/syuilo/misskey/issues/6863 と、現在の実装の中間のような実装。
チャートのコミットメソッドが呼ばれると、すぐレコード挿入するのではなく、メモリにコミット情報を載せておくだけにする。
それで定期的に、メモリにある情報をまとめて、レコード挿入するようにする。
そうすることで現在よりもパフォーマンスは改善しそう
@syuilo syuilo added 🐢Performance Efficiency related issue/PR ✨Feature This adds/improves/enhances a feature packages/backend Server side specific issue/PR labels Mar 14, 2021
@syuilo syuilo mentioned this issue Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨Feature This adds/improves/enhances a feature packages/backend Server side specific issue/PR 🐢Performance Efficiency related issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve chart performance misskey-dev/misskey
1 participant
@syuilo