Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prelude/urlでquerystringを使用しているがブラウザには存在しない #7854

Closed
mei23 opened this issue Sep 30, 2021 · 2 comments · Fixed by #7855
Closed

prelude/urlでquerystringを使用しているがブラウザには存在しない #7854

mei23 opened this issue Sep 30, 2021 · 2 comments · Fixed by #7855
Assignees
@mei23
Labels
✨Feature This adds/improves/enhances a feature 💚Refactor Rewriting code without changing behavior

Comments

@mei23
Copy link
Contributor

mei23 commented Sep 30, 2021 •
edited
Loading

Summary

prelude/urlでquerystringをimportしているが、本来Nodeにしか存在しないはずなので
ブラウザから使われた場合は、たまたま依存関係で読み込まれた https://www.npmjs.com/package/querystring が使われているに過ぎないみたい 。(Webpack v4の時はたぶんpolyfillだった)
少なくとも明示的にdependenciesに入れるか、別の物を使用するようにする。
@mei23 mei23 added ✨Feature This adds/improves/enhances a feature 💚Refactor Rewriting code without changing behavior labels Sep 30, 2021
@rinsuki
Copy link
Contributor

rinsuki commented Sep 30, 2021

URLSearchParamsとかでよさそう

@syuilo syuilo self-assigned this Sep 30, 2021
@syuilo syuilo closed this as completed in bd9df78 Sep 30, 2021
@mei23 mei23 assigned mei23 and unassigned syuilo Sep 30, 2021
@mei23
Copy link
Contributor Author

mei23 commented Sep 30, 2021

エスケープしないとダメ

@mei23 mei23 reopened this Sep 30, 2021
@mei23 mei23 mentioned this issue Sep 30, 2021
Merged
@mei23 mei23 mentioned this issue Nov 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mei23 mei23

Labels
✨Feature This adds/improves/enhances a feature 💚Refactor Rewriting code without changing behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix prelude/url misskey-dev/misskey
3 participants
@syuilo @rinsuki @mei23