Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar not showing - it might be too early to use the "dvh" unit #9636

Closed
outloudvi opened this issue Jan 17, 2023 · 1 comment
Closed

Sidebar not showing - it might be too early to use the "dvh" unit #9636

outloudvi opened this issue Jan 17, 2023 · 1 comment
Labels
⚠️bug? This might be a bug

Comments

@outloudvi
Copy link
Contributor

tl;dr: Upgrade to Chrome for Android 108+/Firefox for Android 107+/Safari 15.4+ if you cannot call out the sidebar.

💡 Summary

The sidebar won't show after clicking that button.

Misskey 13 uses the new distance unit dvh:

However, it might not be widely supported enough. Chrome for Android is released in Dec 2, 2022, and Edge 108 is released in Dec 5, 2022 - these versions are a bit too new.

I would suggest a compatibility fallback of vh:

> .body {
  height: 100vh;
  height: 100dvh; /* New browsers will apply this instead and old browsers will discard this */
}

🥰 Expected Behavior

The sidebar shows.

🤬 Actual Behavior

The sidebar doesn't show.

📝 Steps to Reproduce

  1. Click the menu button.

📌 Environment

Misskey version: 13.0.0
Your OS: Android
Your browser: Chrome 102.

@outloudvi outloudvi added the ⚠️bug? This might be a bug label Jan 17, 2023
@outloudvi
Copy link
Contributor Author

Duplicate of #9187.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️bug? This might be a bug
Projects
None yet
Development

No branches or pull requests

1 participant