Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/api/channels/followed のページネーションが働いていない #9861

Closed
sim1222 opened this issue Feb 10, 2023 · 2 comments
Closed
Labels
⚠️bug? This might be a bug

Comments

@sim1222
Copy link
Contributor

sim1222 commented Feb 10, 2023

💡 Summary

/api/channels/followed のページネーションが働いていません

🥰 Expected Behavior

ページネーションが働いて続きが表示される

🤬 Actual Behavior

untilIdに値を入れてもDBの一番最後のチャンネル1つのみが帰ってくる?(空の配列が帰ってくるときもある)

📝 Steps to Reproduce

  1. /channels のフォロー中を開く

📌 Environment

Misskey version: 13.5.2 / 12.120.0
Your OS: Windows 11 22H2
Your browser: Google Chrome 109.0.5414.120 (Official Build) (64 ビット) (cohort: Stable)

@sim1222 sim1222 added the ⚠️bug? This might be a bug label Feb 10, 2023
@pantasystem
Copy link

pantasystem commented Feb 15, 2023

このPRで修正PRが上がっていたようですがプロジェクト構造が合わずClosedされしまったようですね・・・
#6706

コードを見たところ反映はされてなさそうですね
https://github.com/misskey-dev/misskey/blob/develop/packages/backend/src/server/api/endpoints/channels/followed.ts#L47

@sim1222
Copy link
Contributor Author

sim1222 commented Oct 19, 2023

現時点では修正されているようなので、Closeしておきます。
https://github.com/misskey-dev/misskey/blob/develop/packages/backend/src/core/QueryService.ts#L43 このへんの変更によって一緒に解決された?)

@sim1222 sim1222 closed this as completed Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️bug? This might be a bug
Projects
None yet
Development

No branches or pull requests

2 participants