Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GBC] Issue to play GBVideoPlayer2 #245

Closed
wwark opened this issue Jan 5, 2024 · 6 comments
Closed

[GBC] Issue to play GBVideoPlayer2 #245

wwark opened this issue Jan 5, 2024 · 6 comments

Comments

@wwark
Copy link

wwark commented Jan 5, 2024

Hi,

The core doesn't behave correctly for running roms generated with GBVideoPlayer2.

Readme explaining working on real hardware;
https://github.com/LIJI32/GBVideoPlayer2/blob/master/README.md

Some test roms here : https://github.com/LIJI32/GBVideoPlayer2/releases

Screenshot of butterfly.gbc:
20240105_010143-butterfly

Thanks,

@paulb-nl
Copy link
Collaborator

paulb-nl commented Jan 5, 2024

The roms size are not padded to a power of 2. The core doesn't support that yet.

It will work if you pad them to the correct size.

@paulb-nl
Copy link
Collaborator

paulb-nl commented Jan 5, 2024

You can leave the issue open to remind me to fix this.

@wwark
Copy link
Author

wwark commented Jan 5, 2024

Thanks a lot 👍 I will test to change the padding of the Rom and leave the issue opened for a fix.

@Toryalai1
Copy link

This seem to have been fixed? Please test @wwark

@wwark
Copy link
Author

wwark commented Jun 18, 2024

@Toryalai1 The issue is still present with butterfly.gbc (not pactched with the padding change)

@wwark
Copy link
Author

wwark commented Jun 18, 2024

Sorry I respond to quickly I didn't check with the last unstable it is working now 👍
thank you @Toryalai1 for the ping and thank you @paulb-nl for the fix.

the ticket is closed

@wwark wwark closed this as completed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants