Add option to enable disconnect notifications

[MisterTea]

ET used to notify people on disconnect but this was disabled since it caused issues with "tmux -CC". This issue is to add that back as an option for people who do not use tmux control mode

[MisterTea]

I tried to revive 118210c but it doesn't work well in many cases. Basically, this is very hard to do without a deep integration with a terminal emulator. I could pass some escape sequence letting the terminal emulator know that there is a disconnect, but they would have to render something and handle removing it after we reconnect.

[MisterTea]

Actually maybe I can change the title of the window. Let me look into that

[MisterTea]

Actually it's non-trivial to change the window title. I tried setting PROMPT_COMMAND but that doesn't seem to be portable :-/

[krayon]

Perhaps you could do it for users of tmux at least, by manipulating the status bar(s)? In the event control mode allows for setting stuff like that, you could probably flash a colour or similar? Seems there's a fair bit of customisation available:
https://leanpub.com/the-tao-of-tmux/read#status-bar

As long as you can retrieve current settings, you could change it, then change it back after a delay. You could even have a place holder for an indicator (such as "%%ETDCNT") that could contain the number of disconnections etc.

I am not sure how feasible all this is, just a thought.

[MisterTea]

@krayon This is a great idea but I don't have time at the moment. Would this be something that you would be interested in submitting a PR for? If you made a standalone C++ class with a connect() disconnect() API I can write the logic to call it.

[ddickstein]

Any further plans here? This would be really helpful, especially when trying to differentiate cases of disconnection vs frozen programs at a glance. (The tmux approach proposed would work for me)

[MisterTea]

@ddickstein Care to submit a PR? :-)

I'm a tmux -CC user so this isn't high pri for me TBQH but happy to review a PR for it.

[ddickstein]

What changes do you think are necessary to get it to work? I haven't spent much time working in C++ and I don't know the codebase here. Do you have a rough sense of how much work it is and what the steps would be?

[krayon]

@MisterTea I absolutely would but unfortunately I don't have the time and I don't actually use EternalTCP myself. I was just evaluating it for someone and had that idea. I'm sorry I can't offer a PR for this :(