-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flow Control #631
Comments
|
ET has flow control but it's based on lines-per-second (currently set to 1024 lines-per-second): https://github.com/MisterTea/EternalTerminal/blob/master/src/terminal/UserTerminalHandler.cpp#L110 In your example, there are no newlines so the flow control doesn't kick in. Feel free to change the logic to do roughly 80k characters per second and that would fix the example you posted. |
@MisterTea This also repros if you just run |
Oh, interesting! What happens if you compile with a much lower lines per second? |
Haven't had a chance to try out an end to end compile. This python script might be helpful though:
When run through ET, you can see that the time that gets printed out starts lagging real time. This suggests that ET is not putting back pressure on the stdout of the underlying process. OTOH with SSH directly, everything is in real time. Intuitively, if you have a rate limit (ideally this would not be necessary. 1024 lines / second is rather slow if you cat a long file) you also need to put backpressure on the remote end. If you allow buffering, you are always going to be seeing old output, which means that a control-C can't take effect instantly. |
I've noticed that ET struggles with Flow Control. If you run
cat /dev/zero | base64 -w 0
it is not possible to send a ^C to the server. Using SSH directly it works fine.
The text was updated successfully, but these errors were encountered: