Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making app alive again. #29

Merged
merged 7 commits into from Oct 17, 2020
Merged

Making app alive again. #29

merged 7 commits into from Oct 17, 2020

Conversation

Hassan-Elseoudy
Copy link
Contributor

What has been changed.

  • A New file for Api Messages (to be changeable later).
  • Linking roles with indexes in a map, ease of editing from one place.
  • I also didn't want to break your algorithm searching for names, so I added a new extractRoleName.
    I tried to link your original strings with the new Enums.

example:
input(ROLE_TRIAL_SUPERVISOR) -> will return(Trial Supervisor)
input(ROLE_PUBLIC_SECTOR) -> will return(Public Sector)

:) Ping me if you needed any edits and have a nice night.

IMO, you need to use Visitor Design pattern for specifying roles.

@iamysko iamysko linked an issue Oct 17, 2020 that may be closed by this pull request
Copy link
Owner

@iamysko iamysko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewed all changes. Great work!!

@iamysko iamysko merged commit 392a8ec into iamysko:master Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move hard-coded values
2 participants