error loading new panorama

[Fernando-Checa]

Describe the bug

I get this error when changing panorama

setPanorama(panorama, options)

this is the full error:

In the demo, click on the marker to load a new panorama and get the error.

if I switch back to 5.7.1 everything works fine.

Online demo URL

https://jsfiddle.net/ferpando/f40v8ewu/2/

Photo Sphere Viewer version

5.7.2

Plugins loaded

No response

OS & browser

MacOs Sonoma, Brave Versión 1.62.162 Chromium: 121.0.6167.164 (Build oficial) (arm64)

Additional context

No response

[mistic100]

Your example does not exhibit this problem. There is a problem however loading your panorama (probably a CORS issue).

If I use viewer.setPanorama( baseUrl + 'sphere-test.jpg'); instead there is no error.

Aren't you calling markersPlugin.clearMarkers(); too ?

[Fernando-Checa]

Yes, it makes no difference. https://jsfiddle.net/ferpando/f40v8ewu/3/ Change the panorama for another you have locally 

[mistic100]

There is a misundertanding : I am asking if you where already calling "clearMarkers" and forgot to add it to your first example ?

I identified a problem in the removeMarker method (and by extension clearMarkers). But if you also have to problem without calling removeMarkers, this is another problem I didn't identified.

(by the way your https://paulbourke.net/panorama/sphere2persp/pano4.png image is huge and takes ages to load, you should consider using the tiles adapter and test on Firefox, which is enable to resize large images)

[Fernando-Checa]

In my own code yes I call the clearMarkers() method. In the first example I didn’t call the method. On the last example, I added the method, but the result es the same error. Regards

[mistic100]

Well no, in your first demo the error is not the same !

[mistic100]

Anyway I fixed the problem I identified an published the plugin as version 5.7.2-fix.1

If this is not your problem you can open a new issue, and this time make sure the error you report is actually the error on the demo.

[Fernando-Checa]

The error is the same on my end on both examples. I’m gonna test the new release and tell you.

[Fernando-Checa]

It seems the issue is fixed with this fix.1 release. Regards

…

El 6 mar 2024, a las 13:47, Damien Sorel ***@***.***> escribió: 5.7.2-fix.1

[Fernando-Checa]

Hello again.. the error is back with 5.7.2.
Can't load new panorama files

Press the green marker in the demo to get this error

https://jsfiddle.net/ferpando/f40v8ewu/4/

my browser gives a bit more info

[mistic100]

If you got to NPM you will see there is fix of the markers plugin https://www.npmjs.com/package/@photo-sphere-viewer/markers-plugin

So use "5.7.2-fix.1", or simply "5" or "5.2" to automatically get the fixes

[Fernando-Checa]

That’s what it says but it is not fixed.Please check the demo.On 5.7.2.fix1 works but not in 5.7.2

[Fernando-Checa]

Just to clarify, I thought this fix was incorporated on the 5.7.2 release, with I see it not. So I still need to use the fix1 release for the moment?

[mistic100]

When a version is published to NPM is cannot be replaced. That's why I marked 5.7.2 as deprecated.

[Fernando-Checa]

Ok then. I didn’t know that. I’ll wait then for the next version to update the files. Thank you and sorry for the confusion.