Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tilting of camera in "roll" direction - Gyro plugin #1258

Closed
jywarren opened this issue Mar 7, 2024 · 12 comments
Closed

Tilting of camera in "roll" direction - Gyro plugin #1258

jywarren opened this issue Mar 7, 2024 · 12 comments
Labels
Milestone

Comments

@jywarren
Copy link

jywarren commented Mar 7, 2024

Describe your problem

I've used another pano app which is not as nice as this one, but it does have gyroscope code which lets the user tilt the camera, and the scene follows the tilt, like this:

image

Sorry I don't quite have the vocabulary to describe this kind of tilt -- maybe "device roll"?

But when holding the camera it does really feel more like a window into the photosphere, vs. having this dimension fixed.

To try this out, you can test here: https://spano.pyrik.dev/ (I'm testing on a Pixel 5 phone and an iPad Air)

I looked at this code a bit but it seems to use standard A-Frame controls so I don't quite know where this is happening. Is this possible using PSV?

Thank you for your incredible documentation and a wonderful library!

Online demo URL

No response

Photo Sphere Viewer version

5.7.2

Plugins loaded

Gyroscope

Additional context

No response

@jywarren
Copy link
Author

jywarren commented Mar 7, 2024

Also sponsored for $30, grateful! I know not everyone can but wanted to show appreciation.

@jywarren jywarren changed the title Tilting of camera Tilting of camera in "roll" direction - Gyro plugin Mar 7, 2024
@mistic100
Copy link
Owner

Hello

you can try this plugin https://photo-sphere-viewer.js.org/plugins/gyroscope.html

@jywarren
Copy link
Author

jywarren commented Mar 7, 2024

Thank you, i'm already using it - but it doesn't seem to allow "roll" tilting as in the illustration at top. It keeps "up" towards the top of the phone, rather than towards the zenith of the sky, does that make sense?

@jywarren
Copy link
Author

jywarren commented Mar 7, 2024

That is, PSV does the right side from the below illustration, but I'm looking for the middle behavior:

image

@mistic100
Copy link
Owner

mistic100 commented Mar 7, 2024

Okay I understand. I'll see what can be done.

edit: sorry for ready your initial message too quickly

@mistic100 mistic100 added feature and removed question labels Mar 7, 2024
@jywarren
Copy link
Author

jywarren commented Mar 7, 2024

Thank you so much! No worries.

@mistic100 mistic100 added this to the 5.7.3 milestone Mar 9, 2024
@mistic100
Copy link
Owner

Added a "roll" option, enabled by default.

You might want to build the lib from the main branch to test it before the next release.

@jywarren
Copy link
Author

I had some trouble with the build process, but I read through the code and it all looks great -- I'm not in a huge rush, so I am happy awaiting the next release! Thank you so much!

@jywarren
Copy link
Author

Hi, I was wondering if you might consider creating a new release soon, as I'm hoping to use this in production soon. Thank you!

Copy link

This feature/bug fix has been released in version 5.7.3.

@jywarren
Copy link
Author

Oh my god it's AMAZING -- the sense of realism in stereo mode in particular is immensely heightened! Thank you!!!

@jywarren
Copy link
Author

It's so smooth! I feel like it'll be less likely to cause nausea in some viewers as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants