Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't change Group condition handling afterAddGroup #682

Closed
ricky-provan opened this issue Apr 19, 2018 · 0 comments
Closed

Can't change Group condition handling afterAddGroup #682

ricky-provan opened this issue Apr 19, 2018 · 0 comments
Labels
feature New feature
Milestone

Comments

@ricky-provan
Copy link

I wasn't sure if this is expected behaviour or not so thought I'd post.

When handling the afterAddGroup event, I noticed that changing the new group's condition seems to have no effect or is overwritten after the event.

I set a up a jsFiddle to show what I mean.

If you run the fiddle handling the afterAddGroup event, after adding a group and a second rule to that new group, the condition is still seen to be the default, "AND". However, if handling the afterAddRule event and following the same steps, the condition is set to "OR".

The logged new value for condition shows as "OR" in both cases. I've also tried using the model of the group parameter model instead of calling "getModel" in the afterAddGroup handler but the results are the same.

I just thought this was odd, should we not be able to change the new group's condition in afterAddGroup?

Thanks in advance!

@mistic100 mistic100 added the feature New feature label Apr 19, 2018
@mistic100 mistic100 modified the milestones: 2.6.0, 2.5.2 Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

No branches or pull requests

2 participants