Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"needs reply to review" label process is broken #3173

Open
petersmythe opened this issue Apr 21, 2024 · 0 comments
Open

"needs reply to review" label process is broken #3173

petersmythe opened this issue Apr 21, 2024 · 0 comments

Comments

@petersmythe
Copy link

Hi @ewpatton @halatmit etc

Please refer to my PR #3160 (comment) as well as the instructions copied below from https://docs.google.com/document/d/1sAw0QObTxTWqRX7GQRCa2z9TIV2r5AKT9UKMFF1acZI/pub#h.ibcvzqybkfp8 (linked directly from https://mit-cml.github.io/appinventor-sources/)

When you add the pull request add are ready for it to be reviewed, add the label “status: needs review” to the pull request. Later, during the review process, the reviewer might change that to “needs reply to review”. After you address the review comments, change the label back to “needs review”. There might be several back-and-forth cycles during the review.

You might not be aware that new contributors do not have the permissions to add or change labels:

image

so this process to indicate the back-and-forth status of the review cycle needs to be revised slightly, please.

Peter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant