Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout proxy lookups #399

Open
Varunram opened this issue Sep 26, 2018 · 2 comments
Open

Timeout proxy lookups #399

Varunram opened this issue Sep 26, 2018 · 2 comments
Labels
trivial Simple changes, not requiring extensive testing or inspection

Comments

@Varunram
Copy link
Contributor

We currently timeout most connections (see #398), but the proxy connection can't be timed out since its a bug / feature not in Go yet. We must do this since this would block control from proceeding further. There are some ugly ways to do this using channels and routines, but it'd be nice if go gives us a workaround we can use (or implement a timeout in the proxy.Dialer.Dual struct). Golang issue: golang/go#27874
@Varunram Varunram changed the title Timeout tracker connections Timeout proxy lookups Sep 26, 2018
@delbonis
Copy link
Collaborator

delbonis commented Oct 2, 2018

#276?

@delbonis delbonis closed this as completed Oct 2, 2018
@delbonis delbonis reopened this Oct 2, 2018
@delbonis
Copy link
Collaborator

delbonis commented Oct 2, 2018

oops didn't mean to close that!

@delbonis delbonis added the trivial Simple changes, not requiring extensive testing or inspection label Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
trivial Simple changes, not requiring extensive testing or inspection
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Varunram @delbonis