Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type-checking issues have surfaced #188

Closed
nukularrr opened this issue Oct 26, 2023 · 0 comments
Closed

Type-checking issues have surfaced #188

nukularrr opened this issue Oct 26, 2023 · 0 comments
Labels
type-checking Involves pyright/mypy or rai_toolbox.typing

Comments

@nukularrr
Copy link
Contributor

Although the python source code hasn't changed, pyright is now surfacing type issues, e.g.:

/home/runner/work/responsible-ai-toolbox/responsible-ai-toolbox/tests/annotations.py:34:42 - error: Argument of type "Type[SGD]" cannot be assigned to parameter "InnerOpt" of type "Partial[Optimizer] | OptimizerType" in function "__init__" Type "Type[SGD]" cannot be assigned to type "Partial[Optimizer] | OptimizerType" Type "Type[SGD]" cannot be assigned to type "(*args: Any, **kwargs: Any) -> Optimizer" Parameter "*args" has no corresponding parameter Parameter "**kwargs" has no corresponding parameter Function return type "SGD" is incompatible with type "Optimizer" "SGD" is incompatible with protocol "Optimizer" "step" is an incompatible type Type "Type[SGD]" cannot be assigned to type "OptimizerType" ... (reportGeneralTypeIssues)

@nukularrr nukularrr added the type-checking Involves pyright/mypy or rai_toolbox.typing label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-checking Involves pyright/mypy or rai_toolbox.typing
Projects
None yet
Development

No branches or pull requests

1 participant