Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in sys_read(), log_write() may be called without begin_op() #49

Open
jeehoonkang opened this issue Nov 18, 2020 · 0 comments
Open

in sys_read(), log_write() may be called without begin_op() #49

jeehoonkang opened this issue Nov 18, 2020 · 0 comments

Comments

@jeehoonkang
Copy link

I think, in sys_read(), log_write() may be called without begin_op(), which may panic due to an assertion: https://github.com/mit-pdos/xv6-riscv/blob/riscv/kernel/log.c#L223

The function call chain I suspect is: sys_read -> fileread -> readi -> bmap -> balloc -> log_write .
Even though a file is only read, it may need to zero-initialize new blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant