Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove subst01 knob #1477

Open
JasonGross opened this issue Nov 1, 2022 · 0 comments
Open

Remove subst01 knob #1477

JasonGross opened this issue Nov 1, 2022 · 0 comments

Comments

@JasonGross
Copy link
Collaborator

Controlling subst01 on a per-field-operation is a kludge to work around the fact that some operations cannot occur in arithmetic expressions in some language backends like C, because they are emitted in the style where we pass in pointers to the return values rather than returning the values.

We should instead have a final pass that let-binds the return-passing-style operations---which should be specified per-backend not per-operation---and then inlines only let-bound variables (not things that are used only once). Then we can hopefully hardcode subst01 to true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant