Vmware ESXi remote builder always uploads iso to ESXi host

[stonith]

The remote ESXi builder always uploads the iso to the ESXi host. Please add a check for filename and compare hash like it works locally.

Local check for initial download compares hash:

2014/06/10 02:12:58 /usr/local/bin/packer-builder-vmware-iso: 2014/06/10 02:12:58 Verifying checksum of /var/lib/go-agent/pipelines/Windows_2008R2_Build_Template/packer_cache/3b1a8a2b5db6e32fd4d1c20b750bf2caf14d3c56f195cd60b6aaa74df079d75d.iso
2014/06/10 02:13:34 /usr/local/bin/packer-builder-vmware-iso: 2014/06/10 02:13:34 Initial checksum matched, no download needed.

Remote upload to ESXi server does not check iso hash:

�[1;32m==> vmware-iso: Uploading ISO to remote machine...�[0m
2014/06/10 02:13:34 ui: �[1;32m==> vmware-iso: Uploading ISO to remote machine...�[0m
2014/06/10 02:13:34 /usr/local/bin/packer-builder-vmware-iso: 2014/06/10 02:13:34 Remote uploading: /var/lib/go-agent/pipelines/Windows_2008R2_Build_Template/packer_cache/3b1a8a2b5db6e32fd4d1c20b750bf2caf14d3c56f195cd60b6aaa74df079d75d.iso
2014/06/10 02:13:34 /usr/local/bin/packer-builder-vmware-iso: 2014/06/10 02:13:34 opening new ssh session
2014/06/10 02:13:34 /usr/local/bin/packer-builder-vmware-iso: 2014/06/10 02:13:34 starting remote command: mkdir -p /vmfs/volumes/datastore1/packer_cache
2014/06/10 02:13:34 /usr/local/bin/packer-builder-vmware-iso: 2014/06/10 02:13:34 remote command exited with '0': mkdir -p /vmfs/volumes/datastore1/packer_cache
2014/06/10 02:13:34 /usr/local/bin/packer-builder-vmware-iso: 2014/06/10 02:13:34 opening new ssh session
2014/06/10 02:13:34 /usr/local/bin/packer-builder-vmware-iso: 2014/06/10 02:13:34 Starting remote scp process:  scp -vt /vmfs/volumes/datastore1/packer_cache
2014/06/10 02:13:34 /usr/local/bin/packer-builder-vmware-iso: 2014/06/10 02:13:34 Started SCP session, beginning transfers...
2014/06/10 02:13:34 /usr/local/bin/packer-builder-vmware-iso: 2014/06/10 02:13:34 Copying input data into temporary file so we can read the length
2014/06/10 02:14:52 /usr/local/bin/packer-builder-vmware-iso: 2014/06/10 02:14:52 Beginning file upload...
2014/06/10 02:19:29 /usr/local/bin/packer-builder-vmware-iso: 2014/06/10 02:19:29 SCP session complete, closing stdin pipe.
2014/06/10 02:19:29 /usr/local/bin/packer-builder-vmware-iso: 2014/06/10 02:19:29 Waiting for SSH session to complete.
2014/06/10 02:19:29 /usr/local/bin/packer-builder-vmware-iso: 2014/06/10 02:19:29 scp stderr (length 92): Sink: C0644 3166720000 3b1a8a2b5db6e32fd4d1c20b750bf2caf14d3c56f195cd60b6aaa74df079d75d.iso

[higebu]

I'll try to add this feature.

[rdr78]

How can I download binaries that has this fix?

On Fri, Jul 18, 2014 at 3:29 PM, Yves Laroche notifications@github.com
wrote:

I've tested this and works, no more uploading [image: 👍]

—
Reply to this email directly or view it on GitHub
#1244 (comment).

[yveslaroche]

@rdr78 There are none, but you can build your own. Clone the git repository and merge the fix and then follow the instructions in the readme to build from source.