Warn that ec2-bundle-vol may ignore some important files #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good! Thanks! Merging. I think secure-by-default should be good. The warning is great. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that the version of ec2-bundle-vol packaged in Ubuntu 13.04 (and, according to online information, previous Ubuntu versions as well) will silently ignore any .gpg and .pem files.
This is done for security purposes, but it is a problem because it drops all files in /etc/ssl and /use/share/keyrings. Consequently, an Ubuntu image created with the default ec2-bundle-vol command will fail to validate signed packages (because the Ubuntu public key has disappeared).
Warn about this issue and suggest the use of the --no-filter option.
Alternatively this could be made the default and users with sensitive files should customize the bundle volume command to exclude them.