Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update net-ssh and net-scp dependencies to use recent dependencies #1361

Closed
wants to merge 2 commits into from
Closed

Conversation

erikh
Copy link

@erikh erikh commented Feb 7, 2013

you may be aware that net-ssh's author has pushed changes which break many pessimistic gem requirements.

http://solutious.com/blog/2013/02/06/net-ssh-gem-code-signed/

several tools like fog, chef, etc depend on these gems, and updated gems have been pushed to reflect the dependency.

Here's a post which explains the upgrade from opscode's point of view:

http://jtimberman.housepub.org/blog/2013/02/06/chef-and-net-ssh-dependency-broken/

Unfortunately I can't use vagrant with my other tooling in bundles, etc because of this.

I ran both the units and acceptance tests before and after the spec change -- there was no difference in the test output, although several acceptance tests failed before and after it.

I'm inclined to think there's no reason to avoid changing this, and the sooner the better. :)

and allow those who depend on other tools which require it to use them
in conjuction.
needed -- it did break acceptance testing though.
@mitchellh
Copy link
Contributor

I cannot merge this back into 1-0-stable. I refuse, unless there is a significant security risk and thorough testing, to make a 2.2 => 2.6 version upgrade in a dependency of a stable release of Vagrant.

I'm willing to look at this change for master.

But note that the net-ssh gems fixed the dependency issues with regards to what Vagrant is dependent on, so things are fine there. Interop with other programs should be done via shelling to an installer-based Vagrant which has its own private Ruby, which avoids gem collisions there as well.

The main issue is if you're using the gem install vagrant, you're gonna have a bad time. This is why Vagrant 1.1 forward won't have a gem install anymore.

@mitchellh mitchellh closed this Feb 7, 2013
@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants