-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track downloaded base boxes URLs into a state file and allow hooking into base boxes removal #2327
Conversation
I like the general idea. I think instead of a dedicated state file, we should just put a state file into each box directory. This will be easier to keep track of because then the whole directory can just be removed when removing the box. I think this should target Vagrant 1.4 due to the magnitude of the change. I'm not convinced yet of the "-i" option when listing boxes. I think maybe we should just show it as part of |
Cool, I'll update the PR accordingly :) Regarding the "-i" option, I just think that if we are going to always show that information we might need to change the output as it is very verbose in my option. If you can think of a better way to present that just LMK :) Just to double check, what do you think about adding those new actions / middlewares? Am I on the right track? As a note to myself, we'll need to make sure the dedicated state file gets skipped when repackaging boxes with |
Oh, and I agree to target 1.4 and I have just tagged this on the 1.4 GitHub milestone ;) |
@mitchellh I've updated the branch with the changes we discussed over IRC but I kept the I don't really like the |
… a builtin action
…s provided to `box list`
Thanks @fgrehm. I'm going to get this in today. I'm going to make some minor changes but the core functionality is great. |
Awesome :) |
Merged! |
🎆 awesome! 🎆 |
I've been willing to do this for a while and last night I was bitten by an issue that would be easily diagnosed if I knew from where the box was downloaded. Basically the URL written on the Vagrantfile was different from the one I downloaded but both boxes had the same name :(
The newly added
StateFile
class can be improved but as usual, I think this is a good start :)Reference: #2293
/cc @mgedmin