Fix documents when using private_network with dhcp

[tobynet]

I wrote in my Vagrantfile following the documents as follows :

  config.vm.provider "virtualbox" do |vb, override|
    override.vm.network "private_network", type: "dhcp"
  end

😄😄😄 Expected 😄😄😄

$ vagrant up
Bringing machine 'default' up with 'virtualbox' provider...
==> default: VirtualBox VM is already running.
$ # No problem

💩💩💩 Actual 💩💩💩

$ vagrant up
There are errors in the configuration of this machine. Please fix
the following errors and try again:

vm:
* An IP is required for a private network.
$ echo $?
1

😱 💔

Next, I correct my Vagrantfile as follows:

  config.vm.provider "virtualbox" do |vb, override|
    override.vm.network "private_network", type: :dchp
  end

Then,

$ vagrant up
Bringing machine 'default' up with 'virtualbox' provider...
==> default: VirtualBox VM is already running.
$ # No problem

✌️✌️✌️

❓ ❓ ❓ Why should I fix it as this patch ❓ ❓ ❓

See below:

at https://github.com/mitchellh/vagrant/blob/v1.5.1/plugins/providers/virtualbox/action/network.rb#L279 :

if options[:type] == :dhcp

at https://github.com/mitchellh/vagrant/blob/v1.5.1/plugins/providers/virtualbox/action/network.rb#L251 :

          options[:ip] = "172.28.128.1" if options[:type] == :dhcp && !options[:ip]

[mitchellh]

We convert to a symbol up here: https://github.com/mitchellh/vagrant/blob/v1.5.1/plugins/providers/virtualbox/action/network.rb#L248

This was a separate issue I just fixed.

[tobynet]

👍 👎