provisioners/ansible: show ansible-playbook in use #3628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,6 +66,8 @@ def provision | |||
| # Support Multiple SSH keys and SSH forwarding: | |||
| env["ANSIBLE_SSH_ARGS"] = ansible_ssh_args unless ansible_ssh_args.empty? | |||
|
|
|||
| show_ansible_playbook_command(env, command) if config.verbose | |||
There was a problem hiding this comment.
I thought it makes sense to "reuse" this option, but following variants would also makes sense:
- always show the command (even if
ansible.verboseisfalse) - add a new option, specific to this new "feature" (i.e.
ansible.show_ansible_playbook_command)
The current solution seems to me a good "trade off", but it is up to you @mitchellh :)
Motivation: By printing out the ansible command used behind the scene, we can ease the support effort to very quickly identify whether a problem is due to Vagrant provisioner or Ansible itself.
|
@mitchellh Okay, unit tests are now fixed. Ready for your review. |
|
ThisLGTM as is. Thanks! :) |
mitchellh
added a commit
that referenced
this pull request
May 5, 2014
provisioners/ansible: show ansible-playbook in use
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
By printing out the ansible command used behind the scene, we can certainly ease
the "support effort" (IRC, Mailing list and Gitub Issues of both projects, Vagrant and Ansible) to quickly identify whether a problem is due to Vagrant provisioner or Ansible itself.