Fixed Admin Verification for HyperV #8510
Conversation
… not that you are in the administrators group since that is not required.
…section of the config. For example
default.vm.provider 'hyperv' do |provider|
provider.vswitch = 'DockerNAT'
end
|
I can confirm that this fixes the admin issues I have when trying to create smb shares |
|
This does indeed fix the issue where the hyperv provider errors stating that the user lacks admin rights when they in fact do. It currently just checks if the user is a system account and that would be very unlikely unless vagrant is running as a service. I would remove the second commit from this PR. Its completely unrelated and IMO unnecessary since the |
|
fwiw, I stumbled into this issue, manually applied the fix and i can also confirmed that it worked. |
|
Regarding the VMSwitch handling, unless this could be updated to handle mutli-homed scenarios, it would better to leave it as is or update the current network processes to handle mutliple adapters/switches. User case, setting up a Router VM to bridge two networks (local host private and lab for example) to create an isolated environment that "borrows" internet access from another network. Also, it's not at all related to the admin verification, so should be on it's own. |
|
It should at least be implemented to not break current Vagrantfiles that use the |
|
Extracted the admin check to isolate change in #8548. Thank you for the PR! |
|
Thank you. I didn't intend for both to be a part of the pull request.
Regards,
John
… On May 1, 2017, at 6:44 PM, Chris Roberts ***@***.***> wrote:
Extracted the admin check to isolate change in #8548. Thank you for the PR!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Fixed admin test to verify that you are running in an elevated shell, not that you are in the administrators group since that is not required.