Skip to content
This repository has been archived by the owner on Aug 18, 2021. It is now read-only.

onDestroy method of features isn't being called #37

Open
jacobweber opened this issue Mar 13, 2013 · 1 comment
Open

onDestroy method of features isn't being called #37

jacobweber opened this issue Mar 13, 2013 · 1 comment

Comments

@jacobweber
Copy link

The onDestroy methods of the Feature classes aren't being called. Feature.initFeatures uses a 'beforedestroy' event to attach the listener, but I don't think that event is ever fired.

In addition, the onDestroy method of Sorter looks like it would break if it were ever called; it uses things like grid.el instead of grid.element.

@jacobweber
Copy link
Author

You can fix it by adding this to List.js:

    destroy: function() {
        this.fireEvent('beforedestroy', this);
        this.callParent(arguments);
    }

And changing Sorter.js like this:

    onDestroy: function() {
        var me     = this,
            grid   = me.getGrid(),
            header = grid.getHeader(),
            el     = header.element;

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant