Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with python 3 #3

Open
eric-wieser opened this issue Jan 5, 2016 · 1 comment
Open

Make compatible with python 3 #3

eric-wieser opened this issue Jan 5, 2016 · 1 comment

Comments

@eric-wieser
Copy link
Contributor

What are your thoughts about using a package like six to make the work on both major python versions?

I'm happy to have a stab at implementing this, but it may come at a slight readability cost.

I'm assuming that you very much want to keep python 2 support.

@mitchgu
Copy link
Owner

mitchgu commented Jan 5, 2016

Feel free to give it a shot.
The main motivations for python 2.7 are: 1. I'm more familiar with it and 2. pypy's version of numpy doesn't support python 3. I'm using numpy for a pretty trivial thing though, so the second point is probably easily overcome.

I just tested the benchmark on the winbook and cpython gives a throughput that is around 50-60% that of pypy. 1770 packets/s vs 2968 packets/s. Both are probably acceptable but I do like keeping the pypy support. Unfortunately both are like 5-6 times slower than on my OSX machine. This is probably why.

eric-wieser referenced this issue in skrub-wreckers/TAMProxy-pyHost Jan 6, 2016
@eric-wieser eric-wieser mentioned this issue Jan 6, 2016
eric-wieser referenced this issue in skrub-wreckers/TAMProxy-pyHost Jan 6, 2016
eric-wieser referenced this issue in skrub-wreckers/TAMProxy-pyHost Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants