Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to Docker action and add Gitlab support #22

Closed
chazwatkins opened this issue Dec 4, 2022 · 2 comments
Closed

Convert to Docker action and add Gitlab support #22

chazwatkins opened this issue Dec 4, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@chazwatkins
Copy link

Hey @mitchspano - This is a cool ci action. Would you be open to converting this to a Docker action and adding support for GitLab? If so, I'm happy to do it.

@mitchspano
Copy link
Owner

Hey Chaz,

Thanks for your interest and support! There are a couple of particular things for this Action which make it tightly coupled to a GitHub pull request context:

  1. Parsing the Git diff from the pull request
  2. Writing the comments with the findings using the GitHub REST API.

I'm curious to hear your thoughts about how writing this as a container action will support the additional context of GitLab.

@mitchspano mitchspano added the enhancement New feature or request label Jan 12, 2023
@chazwatkins
Copy link
Author

Writing it as a container will not make the action support GitLab alone. GitLab doesn't support javascript "actions" but does support docker "actions".

I believe bitbucket pipelines can utilize docker images as well.

The following would need to be done to make it work with multiple git providers:

  • Convert to docker
  • Make diff parsing logic and comment creation generic with plugins for different git providers

If you feel this is outside what you want this repo's scope to be. That's completely understandable. I can always use this repo as inspiration and build one for GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants