Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileConnector.getAttributes wrong usage of getTableAttributes #28

Closed
raulcf opened this issue Jun 20, 2016 · 2 comments
Closed

FileConnector.getAttributes wrong usage of getTableAttributes #28

raulcf opened this issue Jun 20, 2016 · 2 comments
Assignees
@wangsibovictor

Comments

@raulcf
Copy link
Contributor

raulcf commented Jun 20, 2016

There is a comment that says that the usage of getTableAttributes is wrong. I left a FIXME asking what is wrong. Please indicate so that we can see how to fix this.
@wangsibovictor
Copy link
Collaborator

wangsibovictor commented Jun 20, 2016 •
edited

This comment can be removed. I added this comment to say that when we try to get the column type, it should be the first row in the csv file. Otherwise, we are not using it correctly. But now, as we are invoking it multiple times by the readRow interface. The comment will be somehow strange.

@raulcf
Copy link
Contributor Author

raulcf commented Jun 20, 2016

I'll remove it, thanks.

@raulcf raulcf closed this as completed Jun 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wangsibovictor wangsibovictor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raulcf @wangsibovictor