Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whisper example missing NNDecodingTask definition #143

Closed
1 task
keren-riverside opened this issue Jan 8, 2023 · 2 comments
Closed
1 task

Whisper example missing NNDecodingTask definition #143

keren-riverside opened this issue Jan 8, 2023 · 2 comments
Labels
Type : Documentation 📝 The Issue/PR concerns the documentation (README, docstrings, CHANGELOG ...)

Comments

@keren-riverside
Copy link

keren-riverside commented Jan 8, 2023

Description

I am going through the whisper BlindAI example in examples/whisper/BlindAI_Whisper.ipynb and one of the classes used -- NNDecodingTask -- is not defined in the notebook. Can the definition of this class be added so that it will be possible to export different Whisper models (small, large, multi-language etc)?

Why this modification is needed?

Great tutorial that can't be followed 100%...

What documents need to be updated

  • examples/whisper/BlindAI_Whisper.ipynb
@keren-riverside keren-riverside added the Type : Documentation 📝 The Issue/PR concerns the documentation (README, docstrings, CHANGELOG ...) label Jan 8, 2023
@JoFrost
Copy link
Member

JoFrost commented Jan 9, 2023

Hello and thanks for your interest in BlindAI!

Thank you for pointing that out. We found a fix for this and it will be pushed ASAP.
In the meantime, you can also apply the fix yourself easily: Rename NNDecodingTask to MetaModel, and the export will work just fine!

@JoFrost
Copy link
Member

JoFrost commented Jan 9, 2023

FYI, the fixed notebook has been pushed on the repo, you can find it here:
https://github.com/mithril-security/blindai/blob/master/examples/whisper/BlindAI_Whisper.ipynb

@JoFrost JoFrost closed this as completed Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type : Documentation 📝 The Issue/PR concerns the documentation (README, docstrings, CHANGELOG ...)
Projects
None yet
Development

No branches or pull requests

2 participants