New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teams page #263
Teams page #263
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good work getting this up. I'm super happy with the content and organization - good work on the design of these pages!
There's only two big design comment which I think will improve things:
- Laying out the before and after Mito as a calendar-like week so it's easy to parse.
- Making the "Pro roadmap" page just a "Pro" page.
Give me a call if you want to chat about either of these. I'm pretty confidence that both of them would be a big improvement and are worth the .5-1 day that it would take to do them (happy to help out, as well, let me know).
Otherwise it's mostly suggested language changes. Take what you think is good and ignore the rest (I might push harder on some if they matter lots to me). I think that being so close to the language for so long can make it hard to get it, so perhaps think of my eyes as fresh rather than just opinionated :-)
Share notebooks with Mito embedded in them and let colleagues use the Mito Spreadsheet too. > Share notebooks with Mito embedded in them so colleagues can use the Mito spreadsheet also. |
turning toggling code -> toggling code |
Utilize Excel-like formatting and conditional formatting your analysis stand out -> Utilize Excel-like formatting and conditional formatting to make your analysis stand out. |
Mito to write Python from the spreadsheet interface they know and love. -> Mito to write Python using the spreadsheet interface they know and love. |
for code to read and pivot data -> for code to read in and pivot data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good - tiny changes requested. Gonna go peep the actual deployed website.
return ( | ||
<div> | ||
<h1 className={titleStyles.title}> | ||
Ready to make your team Python independent? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think the word "Python independent" means much? Do we want to just be more clear? Perhaps with some alliteration:
- Python pros
- Pythonistas
- Other ideas I'm dumb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me, Python independent means more than something to the effect of Python Pro because I think its directly the issue that teams are trying to address.
margin-top: .5rem; | ||
} | ||
|
||
@media only screen and (min-width: 50em) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, because when they wrap, the Before ones turn into 1 long calendar, which I think is nice. But if they have rounded corners, then it looks bad.
</h2> | ||
<div className={pageStyles.subsection + ' ' + teamsStyles.calendar_section + ' flex-row-desktop-only'}> | ||
<CalendarDay> | ||
<h2>Mon</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a particular reason these are not the full day name (e.g. Mon instead of Monday)? I tried making them the full name, and it still works - let's do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we do the full words then when the screen gets smaller there isn't enough space for all of it, especially with the 4 cards.
trymito.io/pages/teams.tsx
Outdated
<p> Searched StackOverflow for code to read in and pivot data. </p> | ||
</CalendarDay> | ||
<CalendarDay> | ||
<h2>Wed</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya skipped Tuesday!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It takes a day to schedule with the supporting data scientist!
I'd be down to make the top calendar have 4 cards and the bottom calendar have 1... |
Some rephrasing on the calendar cards: Before: After: |
These two files are the biggest files on the website currently. Can you compress them so they load faster? I think I used this website to compress - a 50% reduction would be good! https://imagecompressor.com |
I vote spaghetti, but keep it if you want. Will bring it up again 6 months from now lol |
Minor rephrasing from the plans page:
|
Once you address the above, feel free to merge directly into main! LGTM boi! |
Description
Adds a team page and pro/enterprise roadmap to the plans page
Testing
Please provide a list of the ways you can "access" or use the functionality. Please try and be exhaustive here, and make sure that you test everything you list.
Documentation
Note if any new documentation needs to addressed or reviewed.