Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teams page #263

Merged
merged 15 commits into from May 5, 2022
Merged

Teams page #263

merged 15 commits into from May 5, 2022

Conversation

aarondr77
Copy link
Member

@aarondr77 aarondr77 commented Apr 27, 2022

Description

Adds a team page and pro/enterprise roadmap to the plans page

Testing

Please provide a list of the ways you can "access" or use the functionality. Please try and be exhaustive here, and make sure that you test everything you list.

  • I have tested this on real data that is reasonable and large
  • If I changed the interaction with JupyterLab, I tested that it does not break other programs (like VS Code), and tested that it works "multiple times" in the same notebook.

Documentation

Note if any new documentation needs to addressed or reviewed.

@cla-bot cla-bot bot added the cla-signed label Apr 27, 2022
@vercel
Copy link

vercel bot commented Apr 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
monorepo ✅ Ready (Inspect) Visit Preview May 5, 2022 at 9:42PM (UTC)

Copy link
Member

@naterush naterush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good work getting this up. I'm super happy with the content and organization - good work on the design of these pages!

There's only two big design comment which I think will improve things:

  1. Laying out the before and after Mito as a calendar-like week so it's easy to parse.
  2. Making the "Pro roadmap" page just a "Pro" page.

Give me a call if you want to chat about either of these. I'm pretty confidence that both of them would be a big improvement and are worth the .5-1 day that it would take to do them (happy to help out, as well, let me know).

Otherwise it's mostly suggested language changes. Take what you think is good and ignore the rest (I might push harder on some if they matter lots to me). I think that being so close to the language for so long can make it hard to get it, so perhaps think of my eyes as fresh rather than just opinionated :-)

trymito.io/pages/teams.tsx Outdated Show resolved Hide resolved
trymito.io/pages/teams.tsx Outdated Show resolved Hide resolved
trymito.io/pages/teams.tsx Outdated Show resolved Hide resolved
trymito.io/pages/teams.tsx Outdated Show resolved Hide resolved
trymito.io/pages/teams.tsx Outdated Show resolved Hide resolved
trymito.io/pages/mito_pro_roadmap.tsx Outdated Show resolved Hide resolved
trymito.io/pages/mito_pro_roadmap.tsx Outdated Show resolved Hide resolved
trymito.io/pages/mito_pro_roadmap.tsx Outdated Show resolved Hide resolved
trymito.io/pages/mito_pro_roadmap.tsx Outdated Show resolved Hide resolved
trymito.io/pages/mito_pro_roadmap.tsx Outdated Show resolved Hide resolved
@aarondr77
Copy link
Member Author

Share notebooks with Mito embedded in them and let colleagues use the Mito Spreadsheet too. > Share notebooks with Mito embedded in them so colleagues can use the Mito spreadsheet also.

@aarondr77
Copy link
Member Author

turning toggling code -> toggling code

@aarondr77
Copy link
Member Author

Utilize Excel-like formatting and conditional formatting your analysis stand out -> Utilize Excel-like formatting and conditional formatting to make your analysis stand out.

@aarondr77
Copy link
Member Author

Mito to write Python from the spreadsheet interface they know and love. -> Mito to write Python using the spreadsheet interface they know and love.

@aarondr77
Copy link
Member Author

for code to read and pivot data -> for code to read in and pivot data.

Copy link
Member

@naterush naterush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good - tiny changes requested. Gonna go peep the actual deployed website.

return (
<div>
<h1 className={titleStyles.title}>
Ready to make your team Python independent?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think the word "Python independent" means much? Do we want to just be more clear? Perhaps with some alliteration:

  • Python pros
  • Pythonistas
  • Other ideas I'm dumb

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, Python independent means more than something to the effect of Python Pro because I think its directly the issue that teams are trying to address.

margin-top: .5rem;
}

@media only screen and (min-width: 50em) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2022-05-04 at 4 16 58 PM

It doesn't look like the border radius gets applied when things are small. Do we want it to be?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, because when they wrap, the Before ones turn into 1 long calendar, which I think is nice. But if they have rounded corners, then it looks bad.

trymito.io/styles/globals.css Outdated Show resolved Hide resolved
</h2>
<div className={pageStyles.subsection + ' ' + teamsStyles.calendar_section + ' flex-row-desktop-only'}>
<CalendarDay>
<h2>Mon</h2>
Copy link
Member

@naterush naterush May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason these are not the full day name (e.g. Mon instead of Monday)? I tried making them the full name, and it still works - let's do that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do the full words then when the screen gets smaller there isn't enough space for all of it, especially with the 4 cards.

<p> Searched StackOverflow for code to read in and pivot data. </p>
</CalendarDay>
<CalendarDay>
<h2>Wed</h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya skipped Tuesday!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It takes a day to schedule with the supporting data scientist!

@naterush
Copy link
Member

naterush commented May 4, 2022

Screen Shot 2022-05-04 at 4 23 04 PM

Do we think this links to the best email? I'm fine w/ it, just was wondering...

Edit: I think its good so we're all on the email

@naterush
Copy link
Member

naterush commented May 4, 2022

Screen Shot 2022-05-04 at 4 24 17 PM

Inconsistent capital letters

@naterush
Copy link
Member

naterush commented May 4, 2022

Screen Shot 2022-05-04 at 4 24 46 PM

Top margin on these bois is smaller than the bottom margin. Let's even them out.

@naterush
Copy link
Member

naterush commented May 4, 2022

I'd be down to make the top calendar have 4 cards and the bottom calendar have 1...

@naterush
Copy link
Member

naterush commented May 4, 2022

Some rephrasing on the calendar cards:

Before:
Monday: Searched StackOverflow for Python code to read in an Excel file.
Tuesday: Reached out to supporting data scientist for help with pivot table in pandas.
Wednesday: Tried to make a graph. Got stuck installing Matplotlib.
Thursday: Gave up on Python. Went back to Excel.

After:
Monday: Used Mito to imported, pivot and graph data in a few clicks.

@naterush
Copy link
Member

naterush commented May 4, 2022

Screen Shot 2022-05-04 at 4 28 22 PM

These two files are the biggest files on the website currently. Can you compress them so they load faster? I think I used this website to compress - a 50% reduction would be good! https://imagecompressor.com

@naterush
Copy link
Member

naterush commented May 4, 2022

sh**y

I vote spaghetti, but keep it if you want. Will bring it up again 6 months from now lol

@naterush
Copy link
Member

naterush commented May 4, 2022

Screen Shot 2022-05-04 at 4 29 54 PM

Do we need so much spacing around this link?

@naterush
Copy link
Member

naterush commented May 4, 2022

On the plans page, now that we have the roadmap, the coming soon features can probably go:
Screen Shot 2022-05-04 at 4 30 31 PM

@naterush
Copy link
Member

naterush commented May 4, 2022

Minor rephrasing from the plans page:

  • Mito Pro & Enterprise Roadmap -> Maybe we can just add (coming soon!) or something to this, so that it's clear that we don't have these yet...
  • Share notebooks with Mito embedded in them so colleagues can use the Mito spreadsheet also. -> Share notebooks with Mito embedded in them so colleagues can continue the analysis in Mito.
    Import custom python snippets to use within the Mito Spreadsheet and add completely new step types to the Mito Toolbar. -- Import custom Python snippets to use within the Mito Spreadsheet. Add completely new transformations directly into the Mitosheet.

@naterush
Copy link
Member

naterush commented May 4, 2022

Once you address the above, feel free to merge directly into main! LGTM boi!

@aarondr77 aarondr77 changed the base branch from dev to main May 5, 2022 21:42
@aarondr77 aarondr77 merged commit 6209de8 into main May 5, 2022
@marthacryan marthacryan deleted the teams-page branch March 14, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants