Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow test in integration/ssh/timeouts.yml, Cause Ansible connection timeout #1078

Open
moreati opened this issue May 16, 2024 · 0 comments
Open
Labels
affects-0.3 Issues related to 0.3.X Mitogen releases bug Code feature that hinders desired execution outcome

Comments

@moreati
Copy link
Member

moreati commented May 16, 2024

The test appears to operate on each host sequentially, making the time taken O(number hosts * timeout). Normally all the hosts in a play would execute in parallel (subject to batch size, and serial). Perhaps an unintentional GIL in the select loop? Does Mitogen wait for one host to finish connecting before attempting the next?

As I find speedups elsewhere in the test suite this test is become a larger portion of th total time.

This test checks the behaviour of timeouts, when the target user has a login script containing a long delay. Mitogen counts this agains the overall timeout (Ansible doesn't, I believe this is an intended divergence by the original author).
Offshoot of #1059
build-log-815-81.txt

@moreati moreati added bug Code feature that hinders desired execution outcome affects-0.3 Issues related to 0.3.X Mitogen releases labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-0.3 Issues related to 0.3.X Mitogen releases bug Code feature that hinders desired execution outcome
Projects
None yet
Development

No branches or pull requests

1 participant