Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable the gradient color #371

Closed
rubinatorz opened this issue Oct 27, 2021 · 3 comments
Closed

Option to disable the gradient color #371

rubinatorz opened this issue Oct 27, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request Points: 2 2 agile story points timescale/imminent Ready to be assigned to developers

Comments

@rubinatorz
Copy link

Is it possible to add a feature to disable the gradient color?

If we now don't provide a gradient object, Navigator uses default colors. And if we provide a gradient object with the color of white, this won't work in the new dark mode.

The reason is that we color the (sub) techniques ourselves (via our DeTT&CT tool) and also want to use the aggregate-sum function, so that the sort is working properly. But we don't want the aggregated techniques to have a color.

@isaisabel
Copy link
Contributor

Hi @rubinatorz,

You're right that the "white" color doesn't work well on the dark mode. One possible alternative is to use transparent instead, although this has a bug with the text color in the dark theme (which I will be opening an issue for in a moment).

Here's the "white to blue" gradient in dark and light themes:
Screen Shot 2021-10-27 at 8 31 37 AM
Screen Shot 2021-10-27 at 8 33 48 AM

Here's the same objects with a "transparent to blue" gradient in dark and light themes:
Screen Shot 2021-10-27 at 8 33 54 AM
Screen Shot 2021-10-27 at 8 31 49 AM

I think your improvement (allowing the different color options to be disabled using the "create a customized navigator" feature) is also good. In particular, I think the following options would probably be useful:

  • Enable/disable displaying colors for aggregate scores
  • Enable/disable displaying colors for non-aggregate scores
  • Enable/disable displaying manually assigned colors

@isaisabel isaisabel added enhancement New feature or request Points: 2 2 agile story points timescale/imminent Ready to be assigned to developers timescale/short-term Becomes timescale/imminent in weeks or months and removed timescale/imminent Ready to be assigned to developers labels Oct 27, 2021
@isaisabel
Copy link
Contributor

See also: #372

@rubinatorz
Copy link
Author

Hi @isaisabel

Thanks for your reply! Good to have #372 for the transparency color issue. And your suggestions for disabling the color options are nice, this will give us a lot of flexibility.

@clemiller clemiller added timescale/imminent Ready to be assigned to developers and removed timescale/short-term Becomes timescale/imminent in weeks or months labels Jan 20, 2022
@clemiller clemiller added this to the Version 4.6.0 milestone Jan 20, 2022
@clemiller clemiller removed this from the Version 5.0.0 milestone Feb 8, 2023
@erinehall erinehall self-assigned this Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Points: 2 2 agile story points timescale/imminent Ready to be assigned to developers
Projects
None yet
Development

No branches or pull requests

4 participants