Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate scores calculated on techniques with no sub-techniques #539

Closed
clemiller opened this issue Mar 8, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@clemiller
Copy link
Contributor

clemiller commented Mar 8, 2023

Aggregate scores are being calculated and assigned to all parent-level techniques with scores regardless of sub-techniques, which causes inadvertent behavior when the "non-aggregate score color" option is disabled (feature introduced in #538). Techniques with no sub-techniques are still colored according to the hidden aggregate score they have been assigned. Aggregate scores should only be calculated on techniques with sub-techniques; all other techniques should remain "unscored". When factoring aggregate scores into sorting, prefer techniques scored 0 over unscored.

@clemiller clemiller added the bug Something isn't working label Mar 8, 2023
@clemiller
Copy link
Contributor Author

Changes staged on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant