Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The hideDisabled=True option in the layer is not working. #602

Closed
gnh1201 opened this issue Nov 20, 2023 · 7 comments
Closed

The hideDisabled=True option in the layer is not working. #602

gnh1201 opened this issue Nov 20, 2023 · 7 comments
Assignees
Labels
bug Something isn't working timescale/imminent Ready to be assigned to developers

Comments

@gnh1201
Copy link

gnh1201 commented Nov 20, 2023

I recently confirmed that the hideDisabled=True option is not functioning in the MITRE ATT&CK Navigator. The cause is unknown, but it seems that there is a similar issue in the current version, such as #50.

Additionally, the show/hide disabled button in the MITRE ATT&CK Navigator is also not working.

I was unable to hide information for techniques without relevant details through any method.

@clemiller
Copy link
Contributor

Hi @gnh1201,

Would you be able to provide any further details on the steps to reproduce this issue or an example layer you could share? It appears #50 was addressed in an old version (v2.1) of Navigator and I have not been able to reproduce this issue in the latest version (v4.9.1) with the details provided.

@gnh1201
Copy link
Author

gnh1201 commented Nov 22, 2023

Below is the method to reproduce this issue:

  1. Copy the first example described in the layers/LAYERFORMATv4_5.md file and create a JSON file exactly as it is. In my case, I changed hideDisabled to true, but leaving it as false should not hinder reproducing the issue.
  2. Upload it to the MITRE ATT&CK Navigator.
  3. A popup will appear suggesting an upgrade due to a new schema. Click "No."
  4. The disabled items are not hidden. Pressing the show/hide disabled button has the same result.

@gnh1201
Copy link
Author

gnh1201 commented Nov 22, 2023

My environments

  • Microsoft Edge 119.0.2151.72
  • Google Chrome 119.0.6045.160

@clemiller clemiller added bug Something isn't working timescale/imminent Ready to be assigned to developers labels Nov 22, 2023
@gnh1201
Copy link
Author

gnh1201 commented Nov 23, 2023

While reading through existing closed issues, I found a little bit that seem to be related. It might not be helpful, but I'll add references. #470 #466

@adpare
Copy link
Contributor

adpare commented Nov 28, 2023

Hi @gnh1201,

We followed the steps you outlined to reproduce the issue. It is working as expected on our end. The hide/show disabled button is working based on the value of hideDisabled in the layer file.
What may be causing the issue could be our example layer file layers/LAYERFORMATv4_5.md. Technique T1078 does not fall under the tactic discovery. If you change that to privilege-escalation, you will be able to see the disabled technique.
In addition, disabled techniques with enabled sub-techniques will not be hidden when you click on show/hide.

Hope this solves your issue.

@adpare adpare closed this as completed Nov 28, 2023
@gnh1201
Copy link
Author

gnh1201 commented Nov 29, 2023

Hi @adpare

In addition, disabled techniques with enabled sub-techniques will not be hidden when you click on show/hide.

This is the behavior I expected. However, the problem is that it's not working as intended at the moment.

What may be causing the issue could be our example layer file layers/LAYERFORMATv4_5.md.

The same issue exists in both layers/LAYERFORMAT*.MD and layers/data/samples/*.json.

This issue has not been resolved yet.

@gnh1201
Copy link
Author

gnh1201 commented Nov 29, 2023

Sorry. I misunderstood this feature. I wanted to hide techniques that were not highlighted. As I continued to try, I realized that this is different from the show/hide disabled feature.

I have decided to create a separate 'show/hide not-highlighted' button. Link to the commit

Thank you for addressing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working timescale/imminent Ready to be assigned to developers
Projects
None yet
Development

No branches or pull requests

3 participants