Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force score expressions to be elementwise #81

Closed
isaisabel opened this issue Mar 19, 2019 · 2 comments
Closed

Force score expressions to be elementwise #81

isaisabel opened this issue Mar 19, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@isaisabel
Copy link
Contributor

Currently, score expressions are evaluated by converting the scores on a layer into a flat matrix. For example, a layer with two annotated techniques with the scores 42, 51 would be converted into [42, 51]. The score-expression evaluation is performed on this matrix. This leads to confusion since the requirement for elementwise operators (e.g .* instead of *) is not intuitive (#79).

Rather than documenting this behavior as proposed by #80, instead we should change the way things are calculated to be elementwise by default. This will lead to a more intuitive experience and also allow for expressions like conditionals (e.g a > 40? a : b) which are currently not possible.

@isaisabel isaisabel added the enhancement New feature or request label Mar 19, 2019
@isaisabel
Copy link
Contributor Author

Note: closing #80 since this issue makes it irrelevant.

@isaisabel
Copy link
Contributor Author

Implemented in feature/elementwise-score-ops and merged into develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant