Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedupe NIST tags for 2inspec tools #93

Open
rlakey opened this issue Oct 8, 2021 · 5 comments
Open

Dedupe NIST tags for 2inspec tools #93

rlakey opened this issue Oct 8, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request research Research spikes / prototypes required / etc

Comments

@rlakey
Copy link

rlakey commented Oct 8, 2021

STIG controls with multiple SRG IDs and therefore multiple CCIs often reference the same NIST control family. When running for example xccdf2inspec and this scenario occurs there will be multiple NIST tags that are the same.

For example:

  tag severity: 'medium'
  tag gtitle: 'SRG-OS-000004-GPOS-00004'
  tag satisfies: ['SRG-OS-000004-GPOS-00004', 'SRG-OS-000239-GPOS-00089',
'SRG-OS-000240-GPOS-00090', 'SRG-OS-000241-GPOS-00091',
'SRG-OS-000303-GPOS-00120', 'SRG-OS-000476-GPOS-00221']
  tag gid: 'V-205625'
  tag rid: 'SV-205625r569188_rule'
  tag stig_id: 'WN19-AU-000100'
  tag fix_id: 'F-5890r354794_fix'
  tag cci: ['CCI-000018', 'CCI-001403', 'CCI-001405', 'CCI-001404',
'CCI-002130', 'CCI-000172']
  tag legacy: ['SV-103067', 'V-92979']
  tag nist: ['AC-2 (4)', 'AC-2 (4)', 'AC-2 (4)', 'AC-2 (4)', 'AC-2 (4)', "AU-12
c"]
@rbclark
Copy link
Contributor

rbclark commented Nov 23, 2021

@ejaronne Do you have any input on this? I believe I mentioned this to you at one point and you suggested leaving the duplicates for conversion back to xccdf but I could be misremembering the conversation.

@ejaronne
Copy link
Contributor

This is intended to emulate exactly the related controls from the DISA STIG itself. It is not a duplication. In this case, multiple CCI's support different aspects of AC-2(4), as shown in the DISA STIG Viewer:
image

@aaronlippold
Copy link
Member

aaronlippold commented Nov 24, 2021 via email

@camdenmoors camdenmoors transferred this issue from mitre/inspec_tools Feb 3, 2022
@Amndeep7 Amndeep7 added enhancement New feature or request research Research spikes / prototypes required / etc labels Feb 6, 2022
@rlakey
Copy link
Author

rlakey commented Mar 14, 2023

Just wanted to bring this back up. I believe it still is a duplication of data. STIG Viewer displays this data differently as it shows each CCI and it's corresponding NIST control family where as in InSpec these are separate lists with no relation of CCI to NIST and should be deduped.

The NIST data isn't even in the XCCDF so converting back and forth should not be a concern. STIG Viewer is adding that data based on CCI and so are all of the MITRE tools.

@aaronlippold
Copy link
Member

Yes, I think we can and a uniq to the cci and nist tag generator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request research Research spikes / prototypes required / etc
Projects
None yet
Development

No branches or pull requests

6 participants