Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TokenGranter code #10

Closed
aanganes opened this issue Mar 26, 2012 · 3 comments
Closed

Refactor TokenGranter code #10

aanganes opened this issue Mar 26, 2012 · 3 comments

Comments

@aanganes
Copy link
Contributor

Justin and I had a conversation with Dave Syer today, and decided it would be worth taking a look at how we could move the custom token generation/enhancement code, which we currently have in our TokenGranter impl, into the token service layer instead.

This will change the TokenService interface, which the SECOAUTH team is OK with re-evaluating. We also talked about the TokenService interface having create, enhance, and finish methods.

I will fork our code and push up a new branch to work on these changes.

@ghost ghost assigned aanganes Mar 26, 2012
@aanganes
Copy link
Contributor Author

aanganes commented Apr 9, 2012

Finished, code is in https://github.com/jricher/OpenID-Connect-Java-Spring-Server/tree/refactor_tokengranter_code. I have submitted a pull request to the SECOAUTH team for the changes I made to their code. The pull request is located here: spring-attic/spring-security-oauth#26.

@aanganes aanganes closed this as completed Apr 9, 2012
@aanganes aanganes reopened this Apr 10, 2012
@aanganes
Copy link
Contributor Author

The SECOAUTH team no longer wishes to refactor in this manner. Instead, Dave has suggested adding a TokenEnhancer interface, similar to TokenStore, and leaving it as an implementation detail for individual TokenService implementations.

@aanganes
Copy link
Contributor Author

aanganes commented Jun 1, 2012

@jricher jricher closed this as completed Jun 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants