Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Default Optionals in Deserialization #35

Closed
mitsuhiko opened this issue Feb 13, 2022 · 0 comments · Fixed by #36
Closed

Enable Default Optionals in Deserialization #35

mitsuhiko opened this issue Feb 13, 2022 · 0 comments · Fixed by #36
Labels
design Design considerations

Comments

@mitsuhiko
Copy link
Owner

Currently optionals on deserialization are only optional if #[deser(default)] is set. This is unexpected coming from serde. This should probably be changed and a separate flag could be provided if this is not intended.
@mitsuhiko mitsuhiko added the design Design considerations label Feb 13, 2022
@mitsuhiko mitsuhiko mentioned this issue Feb 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design Design considerations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Options are now defaulted by default mitsuhiko/deser
1 participant
@mitsuhiko