static file would not send to browser correctly

[heavenshell]

Hi,

I've got a issue about static file.

When I put css file in /static/css/style.css in static directory and I described view function with Variable Rules.
Please see sample code on https://gist.github.com/1254213

GET /static/css/style.css request dispatch to view function and css file did not send to browser correctly.
I expected to GET /static/css/style.css should send css file to browser, not dispatch to view function.

Regards.

[thomaslee]

This is happening because werkzeug's Rule.match_compare_key and Rule.build_compare_key give preference to "more complex" rules (i.e. rules with more arguments)

Although it could be argued this is "expected behaviour" it's also kind of counter-intuitive.

Should we afford special precedence to the static directory over user-defined routes?

[hyunchel]

Just to note, this is still relevant issue to the current master.
I was able to reproduce the same behavior with the given sample code.

[jeffwidman]

Forked the gist just in case the OP accidentally removes it in the future: https://gist.github.com/jeffwidman/11d8b8d952abca30756ca4ba01909143

[davidism]

We could allow passing a different rule class to add_url_rule and override Rule.match_compare_key to return something like 1, float('-inf'), 200. But that seems a little extreme for just this. I'm actually surprised this hasn't come up more often, /<string>(/<string>)+ seems like it would be a common rule.