Using new config file for ignoring & force update

[max-sixty]

What happened?

I'm not sure if I'm making a basic mistake here, but thought it would be helpful on the margin to report this in case I'm not:

I have the following config file at insta.yaml:

behavior:
  force_update: true
review:
  include_ignored: false
  include_hidden: false

But running:

cargo insta test -p prql-compiler --lib

• Doesn't force update snapshots. Running with --force-update-snapshots makes a change that the previous command had not made
• Displays a warning warning: some paths are not picked up by cargo insta, use --include-ignored and --include-hidden if you have snapshots in ignored or hidden paths.. Possibly those configs only work under review:?

I confirmed that the config file is getting read (if I make it an invalid YAML file, cargo insta fails)

Reproduction steps

No response

Insta Version

1.24

rustc Version

rustc 1.65.0 (897e37553 2022-11-02)

What did you expect?

No response

[mitsuhiko]

include_ignored and include_hidden are already set to false by default so that won't do anything. I'm not sure why force_update wouldn't be honored however. I ran that against insta itself just now and it updates properly. Any chance this is running an old version of cargo-insta? Though that flag is picked up by insta itself so not sure why that would break anything.

[ngryman]

It seems to be a broader issue, review.include_ignored: true is also not honored (re #326).

[max-sixty]

Sorry, I think cargo-insta was updated but insta in the repo wasn't. force-update does work now that both have been updated.

include_ignored and include_hidden are already set to false by default so that won't do anything.

Yes, makes sense. Is there any way to disable the warning when running tests? That has returned.

(OK if the answer is — "it could be if you want to do a proper contribution"!)

[mitsuhiko]

I'm going to revisit this warning now. There should be a better way to accomplish this.

[max-sixty]

Thanks @mitsuhiko ! Closing this as completed by #334. Very grateful for all your work on this!